Changeset 615 in xtideuniversalbios for trunk/XTIDE_Universal_BIOS/Src/Handlers/Int13h/AH23h_HFeatures.asm

Timestamp:

Aug 7, 2021, 9:02:29 AM (3 years ago)

Author:

aitotat

Message:

• COMMAND_IDLE was not enough to disable standby timer from 1,8" Toshiba HDD. Apparently idle mode is the default mode. Added COMMAND_STAND_BY and that does what COMMAND_IDLE was supposed to do. Without COMMAND_STAND_BY the 1,8" Toshiba HDD experienced some random pauses (=>retry/abort... prompts) especially with Freedos 1.3RC4 but MS-DOS 7.10 (Win98) was mostly OK.
• Added FEATURE_ENABLE_ADVANCED_POWER_MANAGEMENT command to set drive to maximum performance mode when standby timer is disabled. This feature needs a bit more work. See TODO comments in sources.

File:

• trunk/XTIDE_Universal_BIOS/Src/Handlers/Int13h/AH23h_HFeatures.asm (modified) (1 diff)

trunk/XTIDE_Universal_BIOS/Src/Handlers/Int13h/AH23h_HFeatures.asm

@@ -101 +101 @@
 %endif ; MODULE_8BIT_IDE_ADVANCED
 %endif ; MODULE_8BIT_IDE
+
+
+;--------------------------------------------------------------------
+; Enable/disable advanced power management command can be used to scale
+; power consumption and performance. Drive supporting Enable APM might not
+; support Disable AMP so we set the drive to max performance if stand by
+; timer value is 0 (idle/standby disabled)
+;
+;
+; AH23h_EnableOrDisableAdvancedPowerManagement
+;   Parameters:
+;       DL:     Stand By timer value (0=disable APM)
+;       DS:DI:  Ptr to DPT (in RAMVARS segment)
+;       SS:BP:  Ptr to IDEPACK
+;   Returns:
+;       AH:     Int 13h return status
+;       CF:     0 if successful, 1 if error
+;   Corrupts registers:
+;       AL, BX, CX, DX, SI
+;--------------------------------------------------------------------
+%ifdef MODULE_POWER_MANAGEMENT
+AH23h_EnableOrDisableAdvancedPowerManagement:
+    mov     si, FEATURE_ENABLE_ADVANCED_POWER_MANAGEMENT
+    test    dl, dl
+    jnz     SHORT .EnablePowerSave
+    dec     dx
+    dec     dx      ; DL = FEh = Maximum performance
+    jmp     AH23h_SetControllerFeatures
+    
+; TODO: We should add power management level to IDEVARS to be adjustable with xtidecfg
+.EnablePowerSave:
+    mov     dl, 0BFh    ; For Toshiba 1.8" HDD: 80h...BFh = Mode 1
+    jmp     AH23h_SetControllerFeatures
+%endif ; %ifdef MODULE_POWER_MANAGEMENT