Changeset 618 in xtideuniversalbios for trunk/XTIDE_Universal_BIOS/Src/Handlers/Int13h/AH23h_HFeatures.asm

Timestamp:

Aug 31, 2021, 2:17:47 PM (3 years ago)

Author:

krille_n_

Message:

Changes:

• Updated the BIOS makefile. Added the NO_ATAID_CORRECTION define back to the Tiny build as I've realized that the correction code should not be needed for builds without MODULE_EBIOS. Also added a new makefile target 'custom' to make it easier for people to make custom builds.
• Fixed a bug where calling INT 13h/AH=15h for drives not handled by XUB (floppy drives for example) would return an error due to the fact that any non-zero return value in AH from the other BIOS would cause the CF to be set in Int13h_SetErrorCodeToIntpackInSSBPfromAH. The return path is now via Int13h_ReturnFromHandlerWithoutStoringErrorCode which means that no status/error code will be returned in the BDA but that should not be a problem as the other BIOS should do that anyway. This change also fixed another potential problem where return values in DL from the other BIOS were assumed to be drive numbers when MODULE_SERIAL_FLOPPY is included in the build.
• Minor optimizations and fixes.

File:

• trunk/XTIDE_Universal_BIOS/Src/Handlers/Int13h/AH23h_HFeatures.asm (modified) (2 diffs)

trunk/XTIDE_Universal_BIOS/Src/Handlers/Int13h/AH23h_HFeatures.asm

@@ -106 +106 @@
 ; Enable/disable advanced power management command can be used to scale
 ; power consumption and performance. Drive supporting Enable APM might not
-; support Disable AMP so we set the drive to max performance if stand by
+; support Disable APM so we set the drive to max performance if stand by
 ; timer value is 0 (idle/standby disabled)
 ;
@@ -126 +126 @@
     test    dl, dl
     jnz     SHORT .EnablePowerSave
-    dec     dx
-    dec     dx      ; DL = FEh = Maximum performance
-    jmp     AH23h_SetControllerFeatures
-    
+    mov     dl, 0FEh    ; Maximum performance
+    SKIP2B  f
+
 ; TODO: We should add power management level to IDEVARS to be adjustable with xtidecfg
 .EnablePowerSave:
     mov     dl, 0BFh    ; For Toshiba 1.8" HDD: 80h...BFh = Mode 1
-    jmp     AH23h_SetControllerFeatures
-%endif ; %ifdef MODULE_POWER_MANAGEMENT
+    jmp     SHORT AH23h_SetControllerFeatures
+%endif ; MODULE_POWER_MANAGEMENT