Changeset 242 in xtideuniversalbios for trunk/XTIDE_Universal_BIOS/Src/Initialization/DetectPrint.asm

Timestamp:

Feb 10, 2012, 3:12:40 AM (12 years ago)

Author:

krille_n_@…

google:author:

krille_n_@hotmail.com

Message:

Changes:

• Optimizations (both for size and speed) in IdeTransfer.asm and MemIdeTransfer.asm
• Fixed a bug where the SingleByteRead/Write functions in IdeTransfer.asm would fail on 128 sector transfers.
• Fixed some typos and errors in general, comments etc.

File:

• trunk/XTIDE_Universal_BIOS/Src/Initialization/DetectPrint.asm (modified) (8 diffs)

trunk/XTIDE_Universal_BIOS/Src/Initialization/DetectPrint.asm

@@ -22 +22 @@
     ePUSH_T ax, ROMVARS.szTitle         ; Bios title string
     push    cs                          ; BIOS segment
-        
-DetectPrint_BootMenuPrint_FormatCSSIfromParamsInSSBP_Relay:     
+
+DetectPrint_BootMenuPrint_FormatCSSIfromParamsInSSBP_Relay:
     jmp     BootMenuPrint_FormatCSSIfromParamsInSSBP
 
@@ -32 +32 @@
 ;       CS:CX:  Ptr to "Master" or "Slave" string
 ;       CS:BP:  Ptr to IDEVARS
-;       SI:     Ptr to template string 
+;       SI:     Ptr to template string
 ;   Returns:
 ;       Nothing
@@ -44 +44 @@
                                             ;             DL=COM number character, DH=.bDevice
 
-    push    bp                              ; setup stack for call to 
+    push    bp                              ; setup stack for call to
     mov     bp, sp                          ; BootMenuPrint_FormatCSSIfromParamsInSSBP
 
     push    cx                              ; Push "Master" or "Slave"
-        
+
     mov     cl, (g_szDetectPort-$$) & 0xff  ; Setup print string for standard IDE
                                             ; Note that we modify only the low order bits of CX a lot here,
@@ -55 +55 @@
                                             ; on the same 256 byte page, which is checked in strings.asm.
 
-    cmp     dx, DEVICE_SERIAL_PORT << 8     ; Check if this is a serial device, 
+    cmp     dx, DEVICE_SERIAL_PORT << 8     ; Check if this is a serial device,
                                             ; And also check if DL is zero, check with the jz below
-                                            ; This optimization requires that DEVICE_SERIAL_PORT be 
+                                            ; This optimization requires that DEVICE_SERIAL_PORT be
                                             ; the highest value in the DEVICE_* series, ensuring that
                                             ; anything less in the high order bits is a different device.
 
-    jl      .pushAndPrint                   ; CX = string to print, AX = port address, DX won't be used
+    jb      .pushAndPrint                   ; CX = string to print, AX = port address, DX won't be used
 
     mov     cl, (g_szDetectCOM-$$) & 0xff   ; Setup print string for COM ports
@@ -68 +68 @@
 
     push    dx                              ; Push COM number character
-                                            ; If the strnig is going to be "Auto", we will push a NULL (zero)
-                                            ; here for the COM port number, which will be eaten by the 
-                                            ; print routine (DisplayPrint_CharacterFromAL), resulting in 
+                                            ; If the string is going to be "Auto", we will push a NULL (zero)
+                                            ; here for the COM port number, which will be eaten by the
+                                            ; print routine (DisplayPrint_CharacterFromAL), resulting in
                                             ; just "COM" being printed without a character after it.
-                
+
     mov     cl, (g_szDetectCOMAuto-$$) & 0xff   ; Setup secondary print string for "Auto"
-        
+
     jz      .pushAndPrint                   ; CX = string to print, AX and DX won't be used
-        
+
     mov     cl, (g_szDetectCOMLarge-$$) & 0xff  ; Setup secondary print string for "COMn/xx.yK"
 
@@ -82 +82 @@
     cbw                                     ; clear AH, AL will always be less than 128
     xchg    si,ax                           ; move AX to SI for divide
-    mov     ax,1152                         ; baud rate to displa is 115200/divisor, the "00" is handled
+    mov     ax,1152                         ; baud rate to display is 115200/divisor, the "00" is handled
                                             ; in the print strings
-    xor     dx,dx                           ; clear top 16-bits of dividend
+    cwd                                     ; clear top 16-bits of dividend
     div     si                              ; and divide...  Now AX = baud rate/100, DX = 0 (always a clean divide)
-        
+
     mov     si,10                           ; Now separate the whole portion from the fractional for "K" display
     div     si                              ; and divide...  Now AX = baud rate/1000, DX = low order digit
-        
-    cmp     ax,si                           ; <= 10: "2400", "9600", etc.; >10: "19.2K", "38.4K", etc.
+
+    cmp     ax,si                           ; < 10: "2400", "9600", etc.; >= 10: "19.2K", "38.4K", etc.
     jae     .pushAndPrint
 
     mov     cl, (g_szDetectCOMSmall-$$) & 0xff  ; Setup secondary print string for "COMn/XXy00"
-        
-.pushAndPrint:  
+
+.pushAndPrint:
     push    cx                              ; Push print string
     push    ax                              ; Push high order digits, or port address, or N/A
@@ -102 +102 @@
     mov     si, g_szDetectOuter             ; Finally load SI with wrapper string "IDE %s at %s: "
 
-    jmp     short DetectPrint_BootMenuPrint_FormatCSSIfromParamsInSSBP_Relay    
+    jmp     short DetectPrint_BootMenuPrint_FormatCSSIfromParamsInSSBP_Relay
 
 
@@ -127 +127 @@
     ret
 
-
-
-