Changeset 630 in xtideuniversalbios for trunk/XTIDE_Universal_BIOS_Configurator_v2/Src/Flash.asm

Timestamp:

Dec 31, 2024, 3:38:24 PM (8 days ago)

Author:

Krister Nordvall

Message:

Changes:

• Changed the g_szPCFlashSuccessful string in XTIDECFG to reflect the reality - it turns out ANY key was limited to just ENTER or ESC.
• Removed the NEC V-specific optimization I added in r602 because NEC's documentation completely fails to mention that the ROL4 instruction also changes the high nibble of AL. Huge thanks to vcfed-member dreNorteR for discovering this and also for suggesting an optimization to the physical address conversion code in IdeTransfer.asm.
• Made some changes to the OUTPUT_AL_TO_IDE_REGISTER and OUTPUT_AL_TO_IDE_CONTROL_BLOCK_REGISTER macros as an optimization. This saves 15+12 bytes in builds without MODULE_8BIT_IDE (e.g. the PS/2 builds).
• Other minor optimizations and cleanups.

File:

• trunk/XTIDE_Universal_BIOS_Configurator_v2/Src/Flash.asm (modified) (2 diffs)

trunk/XTIDE_Universal_BIOS_Configurator_v2/Src/Flash.asm

@@ -4 +4 @@
 ;
 ; XTIDE Universal BIOS and Associated Tools
-; Copyright (C) 2009-2010 by Tomi Tilli, 2011-2013 by XTIDE Universal BIOS Team.
+; Copyright (C) 2009-2010 by Tomi Tilli, 2011-2024 by XTIDE Universal BIOS Team.
 ;
 ; This program is free software; you can redistribute it and/or modify
@@ -59 +59 @@
 
 .PollingError:
-    mov     BYTE [bp+FLASHVARS.flashResult], FLASH_RESULT.PollingTimeoutError
-    ret
+    mov     al, FLASH_RESULT.PollingTimeoutError
+    SKIP2B  f
 .DataVerifyError:
-    mov     BYTE [bp+FLASHVARS.flashResult], FLASH_RESULT.DataVerifyError
+    mov     al, FLASH_RESULT.DataVerifyError
+    mov     [bp+FLASHVARS.flashResult], al
     ret