Changeset 630 in xtideuniversalbios for trunk/XTIDE_Universal_BIOS/Src/Device/IDE/IdeCommand.asm

Timestamp:

Dec 31, 2024, 3:38:24 PM (8 days ago)

Author:

Krister Nordvall

Message:

Changes:

• Changed the g_szPCFlashSuccessful string in XTIDECFG to reflect the reality - it turns out ANY key was limited to just ENTER or ESC.
• Removed the NEC V-specific optimization I added in r602 because NEC's documentation completely fails to mention that the ROL4 instruction also changes the high nibble of AL. Huge thanks to vcfed-member dreNorteR for discovering this and also for suggesting an optimization to the physical address conversion code in IdeTransfer.asm.
• Made some changes to the OUTPUT_AL_TO_IDE_REGISTER and OUTPUT_AL_TO_IDE_CONTROL_BLOCK_REGISTER macros as an optimization. This saves 15+12 bytes in builds without MODULE_8BIT_IDE (e.g. the PS/2 builds).
• Other minor optimizations and cleanups.

File:

• trunk/XTIDE_Universal_BIOS/Src/Device/IDE/IdeCommand.asm (modified) (5 diffs)

trunk/XTIDE_Universal_BIOS/Src/Device/IDE/IdeCommand.asm

@@ -4 +4 @@
 ;
 ; XTIDE Universal BIOS and Associated Tools
-; Copyright (C) 2009-2010 by Tomi Tilli, 2011-2023 by XTIDE Universal BIOS Team.
+; Copyright (C) 2009-2010 by Tomi Tilli, 2011-2024 by XTIDE Universal BIOS Team.
 ;
 ; This program is free software; you can redistribute it and/or modify
@@ -39 +39 @@
     mov     al, FLG_DEVCONTROL_SRST | FLG_DEVCONTROL_nIEN
 ; ---
+%define IO_SEQUENCE     ; Do not modify DX while this is in effect!
     OUTPUT_AL_TO_IDE_CONTROL_BLOCK_REGISTER     DEVICE_CONTROL_REGISTER_out
     mov     ax, HSR0_RESET_WAIT_US
@@ -52 +53 @@
 ; ---
     OUTPUT_AL_TO_IDE_CONTROL_BLOCK_REGISTER     DEVICE_CONTROL_REGISTER_out
+%undef IO_SEQUENCE      ; DX can be freely modified again.
     mov     ax, HSR1_RESET_WAIT_US
     call    Timer_DelayMicrosecondsFromAX
@@ -277 +279 @@
 ALIGN JUMP_ALIGN
 OutputSectorCountAndAddress:
+%define IO_SEQUENCE     ; Do not modify DX while this is in effect!
     OUTPUT_AL_TO_IDE_REGISTER   SECTOR_COUNT_REGISTER
 
@@ -287 +290 @@
     mov     al, ch
     OUTPUT_AL_TO_IDE_REGISTER   LBA_HIGH_REGISTER
+%undef IO_SEQUENCE      ; DX can be freely modified again.
     ret