Changeset 630 in xtideuniversalbios for trunk/XTIDE_Universal_BIOS/Src


Ignore:
Timestamp:
Dec 31, 2024, 3:38:24 PM (9 days ago)
Author:
Krister Nordvall
Message:

Changes:

  • Changed the g_szPCFlashSuccessful string in XTIDECFG to reflect the reality - it turns out ANY key was limited to just ENTER or ESC.
  • Removed the NEC V-specific optimization I added in r602 because NEC's documentation completely fails to mention that the ROL4 instruction also changes the high nibble of AL. Huge thanks to vcfed-member dreNorteR for discovering this and also for suggesting an optimization to the physical address conversion code in IdeTransfer.asm.
  • Made some changes to the OUTPUT_AL_TO_IDE_REGISTER and OUTPUT_AL_TO_IDE_CONTROL_BLOCK_REGISTER macros as an optimization. This saves 15+12 bytes in builds without MODULE_8BIT_IDE (e.g. the PS/2 builds).
  • Other minor optimizations and cleanups.
Location:
trunk/XTIDE_Universal_BIOS/Src
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/XTIDE_Universal_BIOS/Src/Device/IDE/IdeCommand.asm

    r625 r630  
    44;
    55; XTIDE Universal BIOS and Associated Tools
    6 ; Copyright (C) 2009-2010 by Tomi Tilli, 2011-2023 by XTIDE Universal BIOS Team.
     6; Copyright (C) 2009-2010 by Tomi Tilli, 2011-2024 by XTIDE Universal BIOS Team.
    77;
    88; This program is free software; you can redistribute it and/or modify
    … …  
    3939    mov     al, FLG_DEVCONTROL_SRST | FLG_DEVCONTROL_nIEN
    4040; ---
     41%define IO_SEQUENCE     ; Do not modify DX while this is in effect!
    4142    OUTPUT_AL_TO_IDE_CONTROL_BLOCK_REGISTER     DEVICE_CONTROL_REGISTER_out
    4243    mov     ax, HSR0_RESET_WAIT_US
    … …  
    5253; ---
    5354    OUTPUT_AL_TO_IDE_CONTROL_BLOCK_REGISTER     DEVICE_CONTROL_REGISTER_out
     55%undef IO_SEQUENCE      ; DX can be freely modified again.
    5456    mov     ax, HSR1_RESET_WAIT_US
    5557    call    Timer_DelayMicrosecondsFromAX
    … …  
    277279ALIGN JUMP_ALIGN
    278280OutputSectorCountAndAddress:
     281%define IO_SEQUENCE     ; Do not modify DX while this is in effect!
    279282    OUTPUT_AL_TO_IDE_REGISTER   SECTOR_COUNT_REGISTER
    280283
    … …  
    287290    mov     al, ch
    288291    OUTPUT_AL_TO_IDE_REGISTER   LBA_HIGH_REGISTER
     292%undef IO_SEQUENCE      ; DX can be freely modified again.
    289293    ret
    290294

  • trunk/XTIDE_Universal_BIOS/Src/Device/IDE/IdeTransfer.asm

    r625 r630  
    44;
    55; XTIDE Universal BIOS and Associated Tools
    6 ; Copyright (C) 2009-2010 by Tomi Tilli, 2011-2023 by XTIDE Universal BIOS Team.
     6; Copyright (C) 2009-2010 by Tomi Tilli, 2011-2024 by XTIDE Universal BIOS Team.
    77;
    88; This program is free software; you can redistribute it and/or modify
    … …  
    264264
    265265    ; Convert ES:SI to physical address
    266 %ifdef USE_386
    267     mov     dx, es
    268     xor     ax, ax
    269     shld    ax, dx, 4
    270     shl     dx, 4
    271     add     si, dx
    272     adc     al, ah
    273     mov     es, ax
    274 
    275 %elifdef USE_186
    276 %ifdef USE_NEC_V
    277     mov     dx, es
    278     xor     ax, ax
    279     eROL4   dl
    280     eROL4   dh
    281     add     si, dx
    282     adc     al, ah
    283     mov     es, ax
    284 
    285 %else
    286     mov     ax, es
    287     rol     ax, 4
    288     mov     dx, ax
    289     and     ax, 0Fh
    290     xor     dx, ax
    291     add     si, dx
    292     adc     al, ah
    293     mov     es, ax
    294 
    295 %endif
     266%ifdef USE_386      ; 17 bytes
     267    mov     dx, es              ; 2
     268    xor     ax, ax              ; 2
     269    shld    ax, dx, 4           ; 3
     270    shl     dx, 4               ; 3
     271    add     si, dx              ; 2
     272    adc     al, ah              ; 2
     273    mov     es, ax              ; 2
     274                            ;------
     275                            ;    16 cycles on 386
     276%elifdef USE_186    ; 17 bytes
     277    mov     ax, es              ; 2
     278    rol     ax, 4               ; 3
     279    mov     dx, ax              ; 2
     280    and     al, 0F0h            ; 2
     281    xor     dx, ax              ; 2
     282    add     si, ax              ; 2
     283    adc     dl, dh              ; 2
     284    mov     es, dx              ; 2
     285                            ;------
     286                            ;    17 cycles on 386
    296287%else ; 808x
    297288    mov     al, 4
    … …  
    301292    mov     cx, dx
    302293    xchg    cx, ax
    303     and     ax, 0Fh
     294    and     al, 0F0h
    304295    xor     dx, ax
    305     add     si, dx
    306     adc     al, ah
    307     mov     es, ax
     296    add     si, ax
     297    adc     dl, dh
     298    mov     es, dx
    308299
    309300%endif

  • trunk/XTIDE_Universal_BIOS/Src/Handlers/Int19h/BootSector.asm

    r597 r630  
    44;
    55; XTIDE Universal BIOS and Associated Tools
    6 ; Copyright (C) 2009-2010 by Tomi Tilli, 2011-2013 by XTIDE Universal BIOS Team.
     6; Copyright (C) 2009-2010 by Tomi Tilli, 2011-2024 by XTIDE Universal BIOS Team.
    77;
    88; This program is free software; you can redistribute it and/or modify
    … …  
    2828;   Returns:
    2929;       ES:BX:  Ptr to boot sector (if successful)
    30 ;       CF:     Set if boot sector loaded successfully
    31 ;               Cleared if failed to load boot sector
     30;       CF:     Cleared if boot sector loaded successfully
     31;               (only matters when jumping to
     32;               Int19h_JumpToBootSectorInESBXOrRomBoot)
    3233;   Corrupts registers:
    33 ;       AX, CX, DH, SI, DI, (DL if failed to read boot sector)
     34;       AX, CX, DH, SI, DI
    3435;--------------------------------------------------------------------
    3536BootSector_TryToLoadFromDriveDL_AndBoot:
    3637    call    DetectPrint_TryToBootFromDL
    3738    call    BootSector_LoadFirstSectorFromDriveDL
     39    inc     dx                                              ; Determine if hard drive or floppy drive without changing the CF
     40    dec     dl
    3841    jnc     SHORT .FirstSectorLoadedToESBX
    3942
    … …  
    4245    ; display error code every time user intends to boot from hard disk
    4346    ; when A then C boot order is used.
    44     test    dl, dl
    45     js      SHORT .PrintFailedToLoadErrorCode   ; Hard Drive
     47    js      SHORT .PrintFailedToLoadErrorCode               ; Hard Drive
    4648    cmp     ah, RET_HD_TIMEOUT
    47     je      SHORT .ReturnWithCFclearSinceFailedToLoadBootSector
     49    je      SHORT BootSector_LoadFirstSectorFromDriveDL.Return
    4850    cmp     ah, RET_HD_NOMEDIA
    49     je      SHORT .ReturnWithCFclearSinceFailedToLoadBootSector
     51    je      SHORT BootSector_LoadFirstSectorFromDriveDL.Return
    5052.PrintFailedToLoadErrorCode:
    51     call    DetectPrint_FailedToLoadFirstSector
    52     jmp     SHORT .ReturnWithCFclearSinceFailedToLoadBootSector
    53 
     53    jmp     DetectPrint_FailedToLoadFirstSector
    5454
    5555.FirstSectorLoadedToESBX:
    56     test    dl, dl
    57     jns     SHORT .AlwaysBootFromFloppyDriveForBooterGames
    58     cmp     WORD [es:bx+510], 0AA55h        ; Valid boot sector?
    59     jne     SHORT .FirstHardDiskSectorNotBootable
    60 .AlwaysBootFromFloppyDriveForBooterGames:
    61     clc     ; Boot Sector loaded successfully
    62     jmp     SHORT Int19h_JumpToBootSectorInESBXOrRomBoot
    63 
    64 .FirstHardDiskSectorNotBootable:
     56    jns     SHORT Int19h_JumpToBootSectorInESBXOrRomBoot    ; Don't check for boot sector signature for floppy booter games
     57    cmp     WORD [es:bx+510], 0AA55h                        ; Valid boot sector?
     58    je      SHORT Int19h_JumpToBootSectorInESBXOrRomBoot    ; With CF cleared
    6559    mov     si, g_szBootSectorNotFound
    66     call    DetectPrint_NullTerminatedStringFromCSSI
    67 .ReturnWithCFclearSinceFailedToLoadBootSector:
    68     clc
    69     ret
     60    jmp     DetectPrint_NullTerminatedStringFromCSSI
    7061
    7162

  • trunk/XTIDE_Universal_BIOS/Src/VariablesAndDPTs/AccessDPT.asm

    r593 r630  
    44;
    55; XTIDE Universal BIOS and Associated Tools
    6 ; Copyright (C) 2009-2010 by Tomi Tilli, 2011-2013 by XTIDE Universal BIOS Team.
     6; Copyright (C) 2009-2010 by Tomi Tilli, 2011-2024 by XTIDE Universal BIOS Team.
    77;
    88; This program is free software; you can redistribute it and/or modify
    … …  
    141141AccessDPT_GetPointerToDRVPARAMStoCSBX:
    142142    call    AccessDPT_GetIdevarsToCSBX
    143     add     bx, BYTE IDEVARS.drvParamsMaster    ; CS:BX points to Master Drive DRVPARAMS
     143    add     bx, BYTE IDEVARS.drvParamsMaster+DRVPARAMS_size ; CS:BX points to Slave Drive DRVPARAMS
    144144    test    BYTE [di+DPT.bFlagsLow], FLGL_DPT_SLAVE
    145     jz      SHORT .ReturnPointerToDRVPARAMS
    146     add     bx, BYTE DRVPARAMS_size             ; CS:BX points to Slave Drive DRVPARAMS
    147 .ReturnPointerToDRVPARAMS:
     145    jnz     SHORT .Return
     146    sub     bx, BYTE DRVPARAMS_size                         ; CS:BX points to Master Drive DRVPARAMS
     147.Return:
    148148    ret
    149149
Note: See TracChangeset for help on using the changeset viewer.