Changeset 615 in xtideuniversalbios for trunk/XTIDE_Universal_BIOS/Src/Handlers/Int13h/AH9h_HInit.asm

Timestamp:

Aug 7, 2021, 9:02:29 AM (3 years ago)

Author:

aitotat

Message:

• COMMAND_IDLE was not enough to disable standby timer from 1,8" Toshiba HDD. Apparently idle mode is the default mode. Added COMMAND_STAND_BY and that does what COMMAND_IDLE was supposed to do. Without COMMAND_STAND_BY the 1,8" Toshiba HDD experienced some random pauses (=>retry/abort... prompts) especially with Freedos 1.3RC4 but MS-DOS 7.10 (Win98) was mostly OK.
• Added FEATURE_ENABLE_ADVANCED_POWER_MANAGEMENT command to set drive to maximum performance mode when standby timer is disabled. This feature needs a bit more work. See TODO comments in sources.

File:

• trunk/XTIDE_Universal_BIOS/Src/Handlers/Int13h/AH9h_HInit.asm (modified) (1 diff)

trunk/XTIDE_Universal_BIOS/Src/Handlers/Int13h/AH9h_HInit.asm

@@ -200 +200 @@
     jz      SHORT .NoPowerManagementSupport
 
+    ; Do we need to disable APM?
+;TODO: We should check APM feature set flag from ATA ID word 83. The above
+;FLGH_DPT_POWER_MANAGEMENT_SUPPORTED is from ATA ID word 82
+    mov     dl, [cs:ROMVARS.bIdleTimeout]
+    push    dx
+    push    dx
+    call    AH23h_EnableOrDisableAdvancedPowerManagement
+
+    ; COMMAND_IDLE is not enough for Toshiba 1,8" HDD since idle mode is the default mode
+    ; COMMAND_STAND_BY seemed to do the trick
+    pop     dx
+    mov     al, COMMAND_STAND_BY
+    mov     bx, TIMEOUT_AND_STATUS_TO_WAIT(TIMEOUT_BSY, FLG_STATUS_BSY)
+    call    Idepack_StoreNonExtParametersAndIssueCommandFromAL
+    STORE_ERROR_FLAG_TO_DPT     FLG_INITERROR_FAILED_TO_INITIALIZE_STANDBY_TIMER
+
+    pop     dx
     mov     al, COMMAND_IDLE
-    mov     dl, [cs:ROMVARS.bIdleTimeout]
     mov     bx, TIMEOUT_AND_STATUS_TO_WAIT(TIMEOUT_BSY, FLG_STATUS_BSY)
     call    Idepack_StoreNonExtParametersAndIssueCommandFromAL