Changeset 596 in xtideuniversalbios for trunk/XTIDE_Universal_BIOS/Src/Initialization/AdvancedAta

Timestamp:

Jul 10, 2018, 1:20:11 AM (6 years ago)

Author:

Krister Nordvall

Message:

Changes:

• Made changes to HotkeyBar.asm to give the Boot Menu and Hotkey Bar a more consistent look. It will probably seem a bit strange at first to people used to the classic theme.
• Added the missing parts of USE_NEC_V that should have been committed with the rest in r593.
• Removed DEFINES_ALL_FEATURES from the BIOS makefile. It didn't work anymore and never really made sense anyway. Added all the official builds to 'make unused' instead which actually uncovered some unused code in the Tiny build.
• XTIDECFG will no longer load color themes from unrecognized versions of the BIOS.
• Other fixes in comments and some minor optimizations.

Location:

trunk/XTIDE_Universal_BIOS/Src/Initialization/AdvancedAta

Files:

• AdvAtaInit.asm (modified) (1 diff)
• Vision.asm (modified) (1 diff)

trunk/XTIDE_Universal_BIOS/Src/Initialization/AdvancedAta/AdvAtaInit.asm

@@ -37 +37 @@
 AdvAtaInit_DetectControllerForIdeBaseInBX:
     ; Detect if system has PCI bus. If it does, we can skip VLB detection. This is
-    ; good thing since detecting Vision QD6850 is dangerous since Intel PIIX4 south bridge
+    ; good thing since detecting Vision QD6580 is dangerous since Intel PIIX4 south bridge
     ; mirrors Interrupt Controller registers from Axh to Bxh. This can lead to faulty
-    ; detection of QD6850 that will eventually crash the system when ports are written.
+    ; detection of QD6580 that will eventually crash the system when ports are written.
 
     ; We should save the 32-bit registers but we don't since system BIOS has stored

trunk/XTIDE_Universal_BIOS/Src/Initialization/AdvancedAta/Vision.asm

@@ -194 +194 @@
     ; Calculate Recovery Time value for QD65xx IDE Timing Register
     xchg    ax, cx
-    eMOVZX  cx, BYTE [cs:bx+.rgbToSubtractFromCycleTimeBasedOnPIOmode]
-    sub     ax, cx
+    mov     bl, [cs:bx+.rgbToSubtractFromCycleTimeBasedOnPIOmode]
+    sub     ax, bx
     mov     bx, bp                      ; Active Time value now in BL
     mov     bp, QD65xx_MAX_RECOVERY_TIME_CLOCKS | (QD65xx_MIN_RECOVERY_TIME_CLOCKS << 8)