Context Navigation

Changeset 244 in xtideuniversalbios

Timestamp:

Feb 10, 2012, 5:18:49 PM (13 years ago)

Author:

gregli@…

google:author:

gregli@hotmail.com

Message:

Removed tiny optimization for DEVICE_SERIAL being the last device type - not worth the fragility and couldn't be checked by the assembler.

Location:

trunk/XTIDE_Universal_BIOS

Files:

r243	r244
91	91	DEVICE_16BIT_ATA EQU (3<<1)
92	92	DEVICE_32BIT_ATA EQU (4<<1)
93		DEVICE_SERIAL_PORT EQU (5<<1) ~~; must be last entry, or remove optimization in DetectPrint~~
	93	DEVICE_SERIAL_PORT EQU (5<<1)
94	94	DEVICE_JRIDE_ISA EQU (6<<1)
95	95

-              r242
+              r244
                                             ; on the same 256 byte page, which is checked in strings.asm.
+    cmp     dx, DEVICE_SERIAL_PORT << 8     ; Check if this is a serial device,
+                                            ; And also check if DL is zero, check with the jz below
+                                            ; This optimization requires that DEVICE_SERIAL_PORT be
+                                            ; the highest value in the DEVICE_* series, ensuring that
+                                            ; anything less in the high order bits is a different device.
+    cmp     dh, DEVICE_SERIAL_PORT          ; Check if this is a serial device
     jb      .pushAndPrint                   ; CX = string to print, AX = port address, DX won't be used
+    jnz     .pushAndPrint                   ; CX = string to print, AX = port address, DX won't be used
     mov     cl, (g_szDetectCOM-$$) & 0xff   ; Setup print string for COM ports
 …
     mov     cl, (g_szDetectCOMAuto-$$) & 0xff   ; Setup secondary print string for "Auto"
+    test    dl, dl                          ; Check if serial port "Auto"
     jz      .pushAndPrint                   ; CX = string to print, AX and DX won't be used

Note: See TracChangeset for help on using the changeset viewer.