Changeset 244 in xtideuniversalbios


Ignore:
Timestamp:
Feb 10, 2012, 5:18:49 PM (11 years ago)
Author:
gregli@…
google:author:
gregli@hotmail.com
Message:

Removed tiny optimization for DEVICE_SERIAL being the last device type - not worth the fragility and couldn't be checked by the assembler.

Location:
trunk/XTIDE_Universal_BIOS
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/XTIDE_Universal_BIOS/Inc/RomVars.inc

    r243 r244  
    9191DEVICE_16BIT_ATA                        EQU (3<<1)
    9292DEVICE_32BIT_ATA                        EQU (4<<1)
    93 DEVICE_SERIAL_PORT                      EQU (5<<1)      ; must be last entry, or remove optimization in DetectPrint
     93DEVICE_SERIAL_PORT                      EQU (5<<1)
    9494DEVICE_JRIDE_ISA                        EQU (6<<1)
    9595
  • trunk/XTIDE_Universal_BIOS/Src/Initialization/DetectPrint.asm

    r242 r244  
    5555                                            ; on the same 256 byte page, which is checked in strings.asm.
    5656
    57     cmp     dx, DEVICE_SERIAL_PORT << 8     ; Check if this is a serial device,
    58                                             ; And also check if DL is zero, check with the jz below
    59                                             ; This optimization requires that DEVICE_SERIAL_PORT be
    60                                             ; the highest value in the DEVICE_* series, ensuring that
    61                                             ; anything less in the high order bits is a different device.
     57    cmp     dh, DEVICE_SERIAL_PORT          ; Check if this is a serial device
    6258
    63     jb      .pushAndPrint                   ; CX = string to print, AX = port address, DX won't be used
     59    jnz     .pushAndPrint                   ; CX = string to print, AX = port address, DX won't be used
    6460
    6561    mov     cl, (g_szDetectCOM-$$) & 0xff   ; Setup print string for COM ports
     
    7571    mov     cl, (g_szDetectCOMAuto-$$) & 0xff   ; Setup secondary print string for "Auto"
    7672
     73    test    dl, dl                          ; Check if serial port "Auto"
    7774    jz      .pushAndPrint                   ; CX = string to print, AX and DX won't be used
    7875
Note: See TracChangeset for help on using the changeset viewer.