Changeset 233 in xtideuniversalbios for trunk/XTIDE_Universal_BIOS_Configurator_v2/Src/Menuitem.asm

Timestamp:

Feb 4, 2012, 6:21:22 PM (12 years ago)

Author:

gregli@…

google:author:

gregli@hotmail.com

Message:

Serial Port: split single byte port and baud into two bytes, taking advantage of the two bytes in DPT_SERIAL, which supports more serial baud rates and in particular fixed a bug where a 4x client machine couldn't talk to a 115.2K server machine. This is a wide change, touching lots of files, but most are shallow changes. DetectPrint.asm took the most significant changes, now it calculates the baud rate to display instead of using characters provided by the Configurator. The Configurator now has a new menu flag, FLG_MENUITEM_CHOICESTRINGS, for specifying that values are not linear and they should be lookedup rather than indexed. Finally, another important bug fixed here is that in some error cases, the serial port code could get into an infinite loop waiting ont the hardware; now it has a timeout.

File:

• trunk/XTIDE_Universal_BIOS_Configurator_v2/Src/Menuitem.asm (modified) (3 diffs)

trunk/XTIDE_Universal_BIOS_Configurator_v2/Src/Menuitem.asm

@@ -289 +289 @@
     mov     ax, [es:di]
 
+    test    BYTE [si+MENUITEM.bFlags], FLG_MENUITEM_BYTEVALUE
+    jz      SHORT .NoConvertWordToByteValue
+    xor     ah, ah              ; conversion needs to happen before call to the reader,
+                                ; in case the reader unpacks the byte to a word
+        
+.NoConvertWordToByteValue:
     mov     bx, [si+MENUITEM.itemValue+ITEM_VALUE.fnValueReader]
     test    bx,bx
@@ -300 +306 @@
     pop     es
 
-    test    BYTE [si+MENUITEM.bFlags], FLG_MENUITEM_BYTEVALUE
-    jnz     SHORT .ConvertWordToByteValue
     test    BYTE [si+MENUITEM.bFlags], FLG_MENUITEM_FLAGVALUE
     jz      SHORT .Return
@@ -309 +313 @@
     jnz     SHORT .Return
     xor     ax, ax
-ALIGN JUMP_ALIGN
-.ConvertWordToByteValue:
-    xor     ah, ah
+
 ALIGN JUMP_ALIGN, ret
 .Return: