Changeset 181 in xtideuniversalbios for trunk/XTIDE_Universal_BIOS_Configurator_v2/Src/Menupages/ConfigurationMenu.asm

Timestamp:

Nov 13, 2011, 3:38:40 PM (12 years ago)

Author:

krille_n_@…

google:author:

krille_n_@hotmail.com

Message:

Changes to all parts of the project:

• Size optimizations.
• Added a define (EXCLUDE_FROM_XTIDECFG) to exclude unused library code from XTIDECFG.
• Tried to minimize time spent with interrupts disabled.
• Some minor attempts to improve speed (reordering instructions etc).
• Tried to improve readability, did some cleanup and fixed some errors in comments.

File:

• trunk/XTIDE_Universal_BIOS_Configurator_v2/Src/Menupages/ConfigurationMenu.asm (modified) (2 diffs)

trunk/XTIDE_Universal_BIOS_Configurator_v2/Src/Menupages/ConfigurationMenu.asm

@@ -168 +168 @@
     call    .GetIdeControllerCountToCX
     dec     cx          ; Primary always enabled
-    jcxz    .PrimaryControllerAlreadyEnabled
+    jz      .PrimaryControllerAlreadyEnabled
     mov     bx, g_MenuitemConfigurationSecondaryIdeController
 ALIGN JUMP_ALIGN
@@ -191 +191 @@
     call    Buffers_GetRomvarsFlagsToAX
     test    ax, FLG_ROMVARS_FULLMODE
+    mov     al, 1   ; Assume lite mode
     jz      SHORT .AllowOnlyOneIdeControllerInLiteMode
 
     mov     bx, ROMVARS.bIdeCnt
     call    Buffers_GetRomvarsValueToAXfromOffsetInBX
-    eMOVZX  cx, al
-    ret
 ALIGN JUMP_ALIGN
 .AllowOnlyOneIdeControllerInLiteMode:
-    mov     cx, 1
+    cbw     ; A maximum of 127 controllers should be sufficient
+    xchg    cx, ax
     ret