Changeset 181 in xtideuniversalbios for trunk/Assembly_Library/Src/Menu/Dialog/DialogFile.asm

Timestamp:

Nov 13, 2011, 3:38:40 PM (12 years ago)

Author:

krille_n_@…

google:author:

krille_n_@hotmail.com

Message:

Changes to all parts of the project:

• Size optimizations.
• Added a define (EXCLUDE_FROM_XTIDECFG) to exclude unused library code from XTIDECFG.
• Tried to minimize time spent with interrupts disabled.
• Some minor attempts to improve speed (reordering instructions etc).
• Tried to improve readability, did some cleanup and fixed some errors in comments.

File:

• trunk/Assembly_Library/Src/Menu/Dialog/DialogFile.asm (modified) (4 diffs)

trunk/Assembly_Library/Src/Menu/Dialog/DialogFile.asm

@@ -265 +265 @@
 .FilterCurrentDirectory:
     cmp     WORD [si+DTA.szFile], CURRENTDIR_CHARACTERS
-    je      SHORT .ReturnWithFiltering
+    je      SHORT .DoFilter
     ret
 
@@ -274 +274 @@
     cmp     WORD [si+DTA.szFile], UPDIR_CHARACTERS
     jne     SHORT .ReturnWithoutFiltering
-.ReturnWithFiltering:
+.DoFilter:
     add     sp, BYTE 2      ; Remove return address from stack
 ALIGN JUMP_ALIGN, ret
@@ -375 +375 @@
 SortDirectoryContentsStringFromESDIwithCountInCX:
     call    Registers_CopyESDItoDSSI
-    call    .AddDirectoryContentsStringLengthToDI
-    mov     bx, .FileStringComparator
-    xchg    dx, cx
-    mov     cx, FILE_STRING_LENGTH
-    jmp     Sort_ItemsFromDSSIwithCountInDXsizeInCXandComparatorInBX
-
-ALIGN JUMP_ALIGN
-.AddDirectoryContentsStringLengthToDI:
+
+    ; Add directory contents string length to DI
     mov     ax, FILE_STRING_LENGTH
+    push    ax
     mul     cx
     add     di, ax
-    ret
+
+    mov     dx, cx
+    pop     cx
+    mov     bx, .FileStringComparator
+    jmp     Sort_ItemsFromDSSIwithCountInDXsizeInCXandComparatorInBX
 
 ;--------------------------------------------------------------------
@@ -395 +394 @@
 ;       ES:DI:  Ptr to second item to compare
 ;   Returns:
-;       FLAGS:  Signed comparition between first and second item
+;       FLAGS:  Signed comparison between first and second item
 ;   Corrupts registers:
 ;       Nothing