Changeset 566 in xtideuniversalbios for trunk/XTIDE_Universal_BIOS/Src/Initialization/AdvancedAta/Vision.asm

Timestamp:

Aug 29, 2013, 12:49:15 AM (11 years ago)

Author:

krille_n_@…

google:author:

krille_n_@hotmail.com

Message:

Changes to XTIDE Universal BIOS:

• Fixed a very old bug (from r150) in IdeError.asm where GetBiosErrorCodeToAHfromStatusAndErrorRegistersInAX would return RET_HD_SEEK_FAIL instead of RET_HD_STATUSERR.
• Optimizations and other fixes.

File:

• trunk/XTIDE_Universal_BIOS/Src/Initialization/AdvancedAta/Vision.asm (modified) (3 diffs)

trunk/XTIDE_Universal_BIOS/Src/Initialization/AdvancedAta/Vision.asm

@@ -179 +179 @@
     test    al, FLG_QDCONTROL_HDONLY_in
     eCMOVNZ ah, FLG_QDCONTROL_NONATAPI              ; Enable Read-Ahead and Post-Write Buffers
-    or      ah, MASK_QDCONTROL_FLAGS_TO_SET
     mov     al, ah
+    or      al, MASK_QDCONTROL_FLAGS_TO_SET
     out     dx, al
     sub     dx, BYTE QD6580_CONTROL_REGISTER
@@ -187 +187 @@
     ; QD6500 has only one channel that can be Primary at 1F0h or Secondary at 170h.
     ; QD6580 always has Primary channel at 1F0h. Secondary channel at 170h can be Enabled or Disabled.
-    mov     bx, [di+DPT.wBasePort]
-    cmp     bx, DEVICE_ATA_PRIMARY_PORT
+    cmp     WORD [di+DPT.wBasePort], DEVICE_ATA_PRIMARY_PORT
     je      SHORT .CalculateTimingTicksForQD6580    ; Primary Channel so no need to modify DX
     times 2 inc dx                                  ; Secondary Channel IDE Timing Register
@@ -216 +215 @@
 
     ; Merge the values to a single byte to output
-    eSHIFT_IM   al, POSITON_QD65XXIDE_RECOVERY_TIME, shl
+    eSHL_IM al, POSITION_QD65XXIDE_RECOVERY_TIME
     or      al, bl
     out     dx, al