Changeset 83 in xtideuniversalbios for trunk/XTIDE_Universal_BIOS

Timestamp:

Jan 6, 2011, 11:00:54 PM (14 years ago)

Author:

krille_n_@…

google:author:

krille_n_@hotmail.com

Message:

Minor size optimizations in various files.

Location:

trunk/XTIDE_Universal_BIOS/Src

Files:

• Boot/BootInfo.asm (modified) (2 diffs)
• Libraries/menu/menu.asm (modified) (5 diffs)

trunk/XTIDE_Universal_BIOS/Src/Boot/BootInfo.asm

@@ -2 +2 @@
 ; Project name  :   IDE BIOS
 ; Created date  :   16.3.2010
-; Last update   :   9.4.2010
-; Author        :   Tomi Tilli
+; Last update   :   6.1.2011
+; Author        :   Tomi Tilli,
+;               :   Krister Nordvall (optimizations)
 ; Description   :   Functions for generating and accessing drive
 ;                   information to be displayed on boot menu.
@@ -50 +51 @@
     sub     bl, [RAMVARS.bFirstDrv]     ; Drive number to index
     mul     bl                          ; AX = Offset inside BOOTNFO array
-    mov     bx, ax                      ; Copy offset to BX
-    add     bx, BOOTVARS.rgBootNfo      ; Add offset to BOOTNFO array
+    add     ax, BOOTVARS.rgBootNfo      ; Add offset to BOOTNFO array
+    xchg    bx, ax                      ; Copy result to BX
     ret
 

trunk/XTIDE_Universal_BIOS/Src/Libraries/menu/menu.asm

@@ -2 +2 @@
 ; Project name  :   Menu library
 ; Created date  :   9.11.2009
-; Last update   :   21.1.2010
-; Author        :   Tomi Tilli
+; Last update   :   6.1.2011
+; Author        :   Tomi Tilli,
+;               :   Krister Nordvall (optimizations)
 ; Description   :   ASM library to menu system.
 ;
@@ -418 +419 @@
     mov     [bp+MENUVARS.wItemSel], ax
     mov     [bp+MENUVARS.wItemTop], ax
-    mov     cx, -1                  ; Invalidate all items
+    xchg    cx, ax                  ; CX = 0
+    dec     cx                      ; CX = -1 (Invalidate all items)
     or      dl, MFL_UPD_ITEM
 %endif
@@ -544 +546 @@
     add     dl, [bp+MENUVARS.bVisCnt]       ; Inc to one past...
     adc     dh, 0                           ; ...last visible menuitem
-    cmp     ax, dx                          ; Over last visible?
-    jae     .RetFalse                       ;  If so, return false
+    cmp     ax, dx                          ; Over last visible or not?
+    cmc                                     ; Either way, fall through
+ALIGN JUMP_ALIGN                            ; CF will reflect TRUE/FALSE
+.RetFalse:
+    cmc
     pop     dx
-    ret                                     ; Return with CF set
-ALIGN JUMP_ALIGN
-.RetFalse:
-    pop     dx
-    clc
     ret
 
@@ -631 +631 @@
 Menu_ShowYNDlg:
     mov     dx, MenuDlg_YNEvent ; Offset to event handler
+    jmp     ContinueMenuShowDlg
+
+
+;--------------------------------------------------------------------
+; Shows dialog that asks any string from user.
+;
+; Menu_ShowStrDlg
+;   Parameters:
+;       BL:     Dialog width with borders included
+;       CX:     Buffer length with STOP included
+;       SS:BP:  Ptr to MENUVARS
+;       ES:DI:  Ptr to STOP terminated string to display
+;       DS:SI:  Prt to buffer to receive string
+;   Returns:
+;       AX:     String length in characters without STOP
+;       CF:     Set if string inputted successfully
+;               Cleared if user cancellation
+;   Corrupts registers:
+;       BX, CX, DX
+;--------------------------------------------------------------------
+ALIGN JUMP_ALIGN
+Menu_ShowStrDlg:
+    mov     dx, MenuDlg_StrEvent    ; Offset to event handler
+ContinueMenuShowDlg:
     call    MenuDlg_Show
     push    ax
@@ -641 +665 @@
 
 ;--------------------------------------------------------------------
-; Shows dialog that asks any string from user.
-;
-; Menu_ShowStrDlg
-;   Parameters:
-;       BL:     Dialog width with borders included
-;       CX:     Buffer length with STOP included
-;       SS:BP:  Ptr to MENUVARS
-;       ES:DI:  Ptr to STOP terminated string to display
-;       DS:SI:  Prt to buffer to receive string
-;   Returns:
-;       AX:     String length in characters without STOP
-;       CF:     Set if string inputted successfully
-;               Cleared if user cancellation
-;   Corrupts registers:
-;       BX, CX, DX
-;--------------------------------------------------------------------
-ALIGN JUMP_ALIGN
-Menu_ShowStrDlg:
-    mov     dx, MenuDlg_StrEvent    ; Offset to event handler
-    call    MenuDlg_Show
-    push    ax
-    pushf
-    call    Menu_RefreshMenu
-    popf
-    pop     ax
-    ret
-
-
-;--------------------------------------------------------------------
 ; Shows progress bar dialog.
 ;