Changeset 621 in xtideuniversalbios for trunk/XTIDE_Universal_BIOS/Src/Device/Serial

Timestamp:

Nov 21, 2021, 2:15:32 PM (3 years ago)

Author:

Krister Nordvall

Message:

Changes:

• Fixed three different bugs all causing the boot menu to show drives using IRQs even though the BIOS had been built without MODULE_IRQ.
• Fixed two bugs in XTIDECFG where loading a BIOS from file and then loading the old settings from EEPROM would
  • overwrite ROMVARS.wFlags in the loaded BIOS file (in RAM). The possibly resulting mismatch of module flags could make it impossible to change settings for modules included in the BIOS or allow changing settings for modules not included in the BIOS.
  • not copy the color theme over to the loaded BIOS.
• Also fixed two very minor bugs in XTIDECFG in BiosFile_LoadFileFromDSSItoRamBuffer and BiosFile_SaveRamBufferToFileInDSSI where the error handling in these routines would close whatever file handle that happened to match the error code returned by DOS in AX.
• Made significant changes to the new flash ROM programming routines to reduce the size. Also fixed a minor bug that would cause the second verification to be skipped and return success when programming a 64 KB block of data.
• Changed the custom BIOS build file names to the 8.3 format.
• Changed some help strings in XTIDECFG to clarify things.
• Other minor optimizations and fixes.

File:

• trunk/XTIDE_Universal_BIOS/Src/Device/Serial/SerialCommand.asm (modified) (2 diffs)

trunk/XTIDE_Universal_BIOS/Src/Device/Serial/SerialCommand.asm

@@ -154 +154 @@
 
     push    si
-    call    FindDPT_ToDSDIforSerialDevice
+    call    FindDPT_ToDSDIforSerialDevice   ; Preserves AX
     pop     si
 %ifdef MODULE_SERIAL_FLOPPY
@@ -162 +162 @@
 ; So, if there was a previously found floppy disk, DI will point to that DPT and we use that value for the slave.
 ;
-    cmp     BYTE [RAMVARS.xlateVars+XLATEVARS.bFlopCntAndFirst], 0
+    cmp     [RAMVARS.xlateVars+XLATEVARS.bFlopCntAndFirst], al  ; Zero?
     je      SHORT .notfounddpt
 .founddpt: