Changeset 607 in xtideuniversalbios for trunk/XTIDE_Universal_BIOS_Configurator_v2/Src/Menupages

Timestamp:

May 21, 2021, 4:12:01 PM (3 years ago)

Author:

Tomi Tilli

Message:

• IRQ can no longer be accidentally left enabled for XT-CF

File:

• trunk/XTIDE_Universal_BIOS_Configurator_v2/Src/Menupages/IdeControllerMenu.asm (modified) (3 diffs)

trunk/XTIDE_Universal_BIOS_Configurator_v2/Src/Menupages/IdeControllerMenu.asm

@@ -593 +593 @@
     ; Standard ATA controllers, including 8-bit mode
 .StandardIdeDevice:
+    ; Enable IRQ for standard ATA
+
     lea     ax, [di-ROMVARS.ideVars0+IDEVARS.wBasePort]
     mov     bl, IDEVARS_size
     div     bl
-    mov     bx, .rgbLowByteOfStdIdeInterfacePorts
+    push    ax
+    mov     bx, .rgbDefaultIrqForStdIde         ; Enable interrupt for primary and secondary IDE
+    xlat
+    mov     [es:di+IDEVARS.bIRQ-IDEVARS.wBasePort], al
+    pop     ax
+    sub     bx, BYTE .rgbDefaultIrqForStdIde - .rgbLowByteOfStdIdeInterfacePorts
     xlat                                        ; DS=CS so no segment override needed
     mov     ah, 1                               ; DEVICE_ATA_*_PORT >> 8
@@ -608 +615 @@
     db      DEVICE_ATA_TERTIARY_PORT    & 0FFh
     db      DEVICE_ATA_QUATERNARY_PORT  & 0FFh
+.rgbDefaultIrqForStdIde:
+    db      14
+    db      15
+    db      0                                   ; These can vary so lets disable by default
+    db      0
 
 .NotStandardIdeDevice:
@@ -645 +657 @@
     mov     ax, DEVICE_XTIDE_DEFAULT_PORT       ; Defaults for 8-bit XTIDE and XT-CF devices
     mov     bx, DEVICE_XTIDE_DEFAULT_PORTCTRL
+    
+    ; XT-CF does not support IRQ so it must be disabled (IRQ setting is not visible for XT-CF)
+    ; XTIDE does not use IRQs by default
+    mov     BYTE [es:di+IDEVARS.bIRQ-IDEVARS.wBasePort], 0
 
 .WriteNonSerial: