Changeset 596 in xtideuniversalbios for trunk/XTIDE_Universal_BIOS/Src/Menus

Timestamp:

Jul 10, 2018, 1:20:11 AM (6 years ago)

Author:

Krister Nordvall

Message:

Changes:

• Made changes to HotkeyBar.asm to give the Boot Menu and Hotkey Bar a more consistent look. It will probably seem a bit strange at first to people used to the classic theme.
• Added the missing parts of USE_NEC_V that should have been committed with the rest in r593.
• Removed DEFINES_ALL_FEATURES from the BIOS makefile. It didn't work anymore and never really made sense anyway. Added all the official builds to 'make unused' instead which actually uncovered some unused code in the Tiny build.
• XTIDECFG will no longer load color themes from unrecognized versions of the BIOS.
• Other fixes in comments and some minor optimizations.

File:

• trunk/XTIDE_Universal_BIOS/Src/Menus/HotkeyBar.asm (modified) (3 diffs)

trunk/XTIDE_Universal_BIOS/Src/Menus/HotkeyBar.asm

@@ -78 +78 @@
     ; Clear CH if floppy drive is selected for boot
     mov     ch, [es:BOOTVARS.hotkeyVars+HOTKEYVARS.bFlags]
-    ;and        ch, FLG_HOTKEY_HD_FIRST     ; Needed if more flags are added
+;   and     ch, FLG_HOTKEY_HD_FIRST     ; Needed if more flags are added
     call    FormatDriveHotkeyString
 
@@ -96 +96 @@
     call    BootVars_GetLetterForFirstHardDriveToAX
     mov     ah, ANGLE_QUOTE_RIGHT
-    mov     cx, [es:BOOTVARS.hotkeyVars+HOTKEYVARS.bHddLetter]  ; Letter to CL, flags to CH
-    ;and        ch, FLG_HOTKEY_HD_FIRST     ; Needed if more flags are added
+    mov     cx, [es:BOOTVARS.hotkeyVars+HOTKEYVARS.wHddLetterAndFlags]  ; Letter to CL, flags to CH
+;   and     ch, FLG_HOTKEY_HD_FIRST     ; Needed if more flags are added
     xor     ch, FLG_HOTKEY_HD_FIRST     ; Clear CH if HD is selected for boot, set otherwise
     mov     di, g_szHDD
@@ -234 +234 @@
 
 GetSelectedHotkeyDescriptionAttributeToDX:
-    mov     si, ATTRIBUTE_CHARS.cHurryTimeout       ; Selected hotkey
+    mov     si, ATTRIBUTE_CHARS.cHighlightedItem    ; Selected hotkey
     je      SHORT GetDescriptionAttributeToDX       ; From compare with bScancode above and from FormatDriveHotkeyString
 
 GetNonSelectedHotkeyDescriptionAttributeToDX:
-    mov     si, ATTRIBUTE_CHARS.cHighlightedItem    ; Unselected hotkey
+    mov     si, ATTRIBUTE_CHARS.cItem               ; Unselected hotkey
 
     ; Display Library should not be called like this