Changeset 596 in xtideuniversalbios for trunk/XTIDE_Universal_BIOS/Src/Initialization

Timestamp:

Jul 10, 2018, 1:20:11 AM (6 years ago)

Author:

Krister Nordvall

Message:

Changes:

• Made changes to HotkeyBar.asm to give the Boot Menu and Hotkey Bar a more consistent look. It will probably seem a bit strange at first to people used to the classic theme.
• Added the missing parts of USE_NEC_V that should have been committed with the rest in r593.
• Removed DEFINES_ALL_FEATURES from the BIOS makefile. It didn't work anymore and never really made sense anyway. Added all the official builds to 'make unused' instead which actually uncovered some unused code in the Tiny build.
• XTIDECFG will no longer load color themes from unrecognized versions of the BIOS.
• Other fixes in comments and some minor optimizations.

Location:

trunk/XTIDE_Universal_BIOS/Src/Initialization

Files:

• AdvancedAta/AdvAtaInit.asm (modified) (1 diff)
• AdvancedAta/Vision.asm (modified) (1 diff)
• DetectDrives.asm (modified) (2 diffs)
• Interrupts.asm (modified) (2 diffs)

trunk/XTIDE_Universal_BIOS/Src/Initialization/AdvancedAta/AdvAtaInit.asm

@@ -37 +37 @@
 AdvAtaInit_DetectControllerForIdeBaseInBX:
     ; Detect if system has PCI bus. If it does, we can skip VLB detection. This is
-    ; good thing since detecting Vision QD6850 is dangerous since Intel PIIX4 south bridge
+    ; good thing since detecting Vision QD6580 is dangerous since Intel PIIX4 south bridge
     ; mirrors Interrupt Controller registers from Axh to Bxh. This can lead to faulty
-    ; detection of QD6850 that will eventually crash the system when ports are written.
+    ; detection of QD6580 that will eventually crash the system when ports are written.
 
     ; We should save the 32-bit registers but we don't since system BIOS has stored

trunk/XTIDE_Universal_BIOS/Src/Initialization/AdvancedAta/Vision.asm

@@ -194 +194 @@
     ; Calculate Recovery Time value for QD65xx IDE Timing Register
     xchg    ax, cx
-    eMOVZX  cx, BYTE [cs:bx+.rgbToSubtractFromCycleTimeBasedOnPIOmode]
-    sub     ax, cx
+    mov     bl, [cs:bx+.rgbToSubtractFromCycleTimeBasedOnPIOmode]
+    sub     ax, bx
     mov     bx, bp                      ; Active Time value now in BL
     mov     bp, QD65xx_MAX_RECOVERY_TIME_CLOCKS | (QD65xx_MIN_RECOVERY_TIME_CLOCKS << 8)

trunk/XTIDE_Universal_BIOS/Src/Initialization/DetectDrives.asm

@@ -99 +99 @@
 ; Primary reason is to support dynamic overlay feature in the future. Second reason
 ; is a hack to get Windows 95 load proper IDE drivers.
-; 
+;
 ; The Windows hack has two parts. First part is to try to alter CMOS address 12h as that
 ; is what Windows 95 driver reads to detect IDE drives. Altering is not possible on all
-; systems since CMOS has a checksum but it's location is not standardized. We will first
+; systems since CMOS has a checksum but its location is not standardized. We will first
 ; try to detect valid checksum. If it succeeds, then it is safe to assume this system
 ; has compatible CMOS and we can alter it.
@@ -117 +117 @@
         call    CMOS_Verify10hTo2Dh             ; Can we modify CMOS?
         jnz     SHORT .ClearBdaDriveCount       ; Unsupported BIOS, use plan B
-    
+
         ; Now we can alter CMOS location 12h
         mov     dl, HARD_DISK_TYPES

trunk/XTIDE_Universal_BIOS/Src/Initialization/Interrupts.asm

@@ -65 +65 @@
     mov     ax, [es:BIOS_DISK_INTERRUPT_13h*4]  ; Load old INT 13h offset
     mov     [RAMVARS.fpMFMint13h], ax           ; Store old INT 13h offset
-    
+
     mov     [RAMVARS.fpOldI13h+2], cs
-    mov     WORD [RAMVARS.fpOldI13h], Int13hMFMcompatibilityHandler 
+    mov     WORD [RAMVARS.fpOldI13h], Int13hMFMcompatibilityHandler
 %else
     mov     ax, [es:BIOS_DISK_INTERRUPT_13h*4+2]; Load old INT 13h segment
@@ -252 +252 @@
     xchg    cx, ax              ; IRQ index to CL
     in      al, dx              ; Read Interrupt Mask Register
+%ifdef USE_NEC_V
+    eCLR1   al, cl              ; Clear wanted bit
+%else
     mov     ch, ~1              ; Load bit mask to be rotated
     rol     ch, cl              ; Rotate mask to correct position for clearing
     and     al, ch              ; Clear wanted bit
+%endif
     out     dx, al              ; Write modified Interrupt Mask Register
     pop     cx