Changeset 588 in xtideuniversalbios for trunk/XTIDE_Universal_BIOS/Src/Device/IDE

Timestamp:

Jun 3, 2015, 12:30:54 PM (9 years ago)

Author:

krille_n_@…

google:author:

krille_n_@hotmail.com

Message:

Changes:

• Fixed a bug in AH24h_HSetBlocks.asm from r550. Trying to set a too large block size with an XT-CF card in DMA transfer mode would corrupt the stack.
• Fixed a bug from r545 where the list of devices under g_szDeviceTypeValues in Strings.asm was no longer up to date causing the boot menu to display the wrong string for devices numbered higher than DEVICE_8BIT_XTCF_PIO8.
• Made some fairly significant changes to the XT-CF code to reduce size. Two changes in functionality; 1) Added a simple check to validate the request for a change of the XT-CF transfer mode. 2) Changing transfer mode to use DMA no longer calls AH24h_SetBlockSize if the block size already is within the limits of DMA transfers. UNTESTED
• XTIDECFG now clears IDEVARS.bIRQ when changing IDE controller to a serial device to keep the boot menu from displaying it since the serial device doesn't use IRQs at all.
• Other minor optimizations.

File:

• trunk/XTIDE_Universal_BIOS/Src/Device/IDE/IdeWait.asm (modified) (2 diffs)

trunk/XTIDE_Universal_BIOS/Src/Device/IDE/IdeWait.asm

@@ -97 +97 @@
 .PollLoop:
     call    IdeIO_InputStatusRegisterToAL
-    test    al, FLG_STATUS_BSY                  ; Controller busy?
-    jnz     SHORT .UpdateTimeout                ;  If so, jump to timeout update
+    test    al, al                              ; Controller busy? (Check for FLG_STATUS_BSY)
+    js      SHORT .UpdateTimeout                ;  If so, jump to timeout update
     test    al, ah                              ; Test secondary flag
     jnz     SHORT IdeError_GetBiosErrorCodeToAHfromPolledStatusRegisterInAL
@@ -126 +126 @@
 .PollLoop:
     call    IdeIO_InputStatusRegisterToAL
-    test    al, FLG_STATUS_BSY                  ; Controller busy?
-    jz      SHORT IdeError_GetBiosErrorCodeToAHfromPolledStatusRegisterInAL
+    test    al, al                              ; Controller busy? (Check for FLG_STATUS_BSY)
+    jns     SHORT IdeError_GetBiosErrorCodeToAHfromPolledStatusRegisterInAL
     call    Timer_SetCFifTimeout                ; Update timeout counter
     jnc     SHORT .PollLoop                     ; Loop if time left (sets CF on timeout)