Changeset 242 in xtideuniversalbios for trunk/XTIDE_Universal_BIOS/Src/Device/Serial

Timestamp:

Feb 10, 2012, 3:12:40 AM (13 years ago)

Author:

krille_n_@…

google:author:

krille_n_@hotmail.com

Message:

Changes:

• Optimizations (both for size and speed) in IdeTransfer.asm and MemIdeTransfer.asm
• Fixed a bug where the SingleByteRead/Write functions in IdeTransfer.asm would fail on 128 sector transfers.
• Fixed some typos and errors in general, comments etc.

Location:

trunk/XTIDE_Universal_BIOS/Src/Device/Serial

Files:

• SerialCommand.asm (modified) (8 diffs)
• SerialDPT.asm (modified) (1 diff)

trunk/XTIDE_Universal_BIOS/Src/Device/Serial/SerialCommand.asm

@@ -112 +112 @@
         mov     ch,dh
         xor     dh,dh
-        eSHL_IM dx, 2           ; shift from one byte to two        
-        
+        eSHL_IM dx, 2           ; shift from one byte to two
+
         mov     al,[bp+IDEPACK.bSectorCount]
 
@@ -599 +599 @@
 ;          wSerialPortAndBaud Non-Zero:
 ;              previous serial drive not found:   -> Error - Not Found (4)
-;              previosu serial drive found:       -> Continue with wSerialPackedAndBaud (5)
+;              previous serial drive found:       -> Continue with wSerialPackedAndBaud (5)
 ;          wSerialPortAndBaud Zero:
 ;              previous serial drive not found:   -> Error - Not Found (4)
@@ -608 +608 @@
 ;     And as with the int13h/25h case, we just go off and get the needed information using the user's setting.
 ; (2) We are using the special .ideVarsSerialAuto structure.  During drive detection, we would only be here
-;     if we hand't already seen a serial drive (since we only scan if no explicit drives are set),
+;     if we hadn't already seen a serial drive (since we only scan if no explicit drives are set),
 ;     so we go off to scan.
 ; (3) We are using the special .ideVarsSerialAuto structure.  We won't get here during drive detection, but
@@ -633 +633 @@
         pop     si
         jnc     .notfounddpt
-        mov     ax,[ds:di+DPT_SERIAL.wSerialPortAndBaud]
-.notfounddpt:   
+        mov     ax, [di+DPT_SERIAL.wSerialPortAndBaud]
+.notfounddpt:
 
         test    bh, FLG_DRVNHEAD_DRV
@@ -647 +647 @@
         jnz     .identifyDeviceInDX
 
-        or      dx,ax           ; Since DX is zero, this effectively moves the previously found serial drive 
+        or      dx,ax           ; Since DX is zero, this effectively moves the previously found serial drive
                                 ; information to dx, as well as test for zero
         jz      .scanSerial
@@ -672 +672 @@
         pop     cx
         pop     dx
-        
+
         pop     bp
 ;
-; place port and baud word in to the return sector, in a vendor specific area, 
+; place port and baud word in to the return sector, in a vendor specific area,
 ; which is read by FinalizeDPT and DetectDrives
 ;
@@ -732 +732 @@
 ; Begin baud rate scan on this port...
 ;
-; On a scan, we support 6 baud rates, starting here and going higher by a factor of two each step, with a 
+; On a scan, we support 6 baud rates, starting here and going higher by a factor of two each step, with a
 ; small jump between 9600 and 38800.  These 6 were selected since we wanted to support 9600 baud and 115200,
-; *on the server side* if the client side had a 4x clock multiplier, a 2x clock multiplier, or no clock multiplier. 
+; *on the server side* if the client side had a 4x clock multiplier, a 2x clock multiplier, or no clock multiplier.
 ;
 ; Starting with 30h, that means 30h (2400 baud), 18h (4800 baud), 0ch (9600 baud), and
@@ -747 +747 @@
         shr     dh,1
         jz      .nextPort
-        cmp     dh,6            ; skip from 6 to 4, to move from the top of the 9600 baud range 
+        cmp     dh,6            ; skip from 6 to 4, to move from the top of the 9600 baud range
         jnz     .testBaud       ; to the bottom of the 115200 baud range
         mov     dh,4

trunk/XTIDE_Universal_BIOS/Src/Device/Serial/SerialDPT.asm

@@ -13 +13 @@
 ;       Nothing
 ;   Corrupts registers:
-;       AX, BX, CX, DX
+;       AX
 ;--------------------------------------------------------------------
 SerialDPT_Finalize:
         or      byte [di+DPT.bFlagsHigh], FLGH_DPT_SERIAL_DEVICE
         mov     ax, [es:si+ATA6.wVendor]
-        mov     word [di+DPT_SERIAL.wSerialPortAndBaud], ax
+        mov     [di+DPT_SERIAL.wSerialPortAndBaud], ax
         ret