Changeset 220 in xtideuniversalbios

Timestamp:

Jan 25, 2012, 7:13:21 AM (13 years ago)

Author:

gregli@…

google:author:

gregli@hotmail.com

Message:

Serial port code, removed pointer re(normalization) code as the pointer is normalized before we are called and the sector count is kept in the range where we will not need to renormalize.

File:

• trunk/XTIDE_Universal_BIOS/Src/Device/Serial/SerialCommand.asm (modified) (3 diffs)

trunk/XTIDE_Universal_BIOS/Src/Device/Serial/SerialCommand.asm

@@ -211 +211 @@
         pop     es
 
+%if 0
+;;; no longer needed, since the pointer is normalized before we are called and we do not support
+;;; more than 128 sectors (and for 128 specifically, the pointer must be segment aligned).
+;;; See comments below at the point this entry point was called for more details...
 .nextSectorNormalize:           
-
-        call    Registers_NormalizeESDI 
+        call    Registers_NormalizeESDI
+%endif
         
         pop     ax              ; load command byte (done before call to .nextSector on subsequent iterations)
@@ -329 +333 @@
         out     dx,al           ; ACK with next sector number
 
+%if 0
+;;; This code is no longer needed as we do not support more than 128 sectors, and for 128 the pointer
+;;; must be segment aligned.  If we ever do want to support more sectors, the code can help...
+        
 ;
 ; Normalize buffer pointer for next go round, if needed.
@@ -371 +379 @@
         jl      short .nextSector       ; OF<>SF, branch for all cases but 7f, fe, and ff
 
-%if 0
-        jpo     short .nextSector       ; if we really wanted to avoid normalizing for ff, this
+;       jpo     short .nextSector       ; if we really wanted to avoid normalizing for ff, this
                                         ; is one way to do it, but it adds more memory and more
                                         ; cycles for the 7f and fe cases.  IMHO, given that I've
                                         ; never seen a request for more than 7f, this seems unnecessary.
+
+        jmp     short .nextSectorNormalize  ; our two renormalization cases (plus one for ff)
+
+%else
+        
+        jmp     short .nextSector       
+        
 %endif
-
-        jmp     short .nextSectorNormalize  ; our two renormalization cases (plus one for ff)
 
 ;---------------------------------------------------------------------------