Changeset 194 in xtideuniversalbios for trunk/XTIDE_Universal_BIOS/Src/Boot

Timestamp:

Nov 17, 2011, 11:07:58 AM (13 years ago)

Author:

gregli@…

google:author:

gregli@hotmail.com

Message:

ifdef'd out more unused code. Also added a tool for looking through the listing and the output of the precompiler to aid in finding dead code. Some changes in the files are to add annotations for the tool to avoid false positives.

Location:

trunk/XTIDE_Universal_BIOS/Src/Boot

Files:

• BootMenuEvent.asm (modified) (2 diffs)
• BootMenuPrint.asm (modified) (4 diffs)
• BootMenuPrintCfg.asm (modified) (8 diffs)

trunk/XTIDE_Universal_BIOS/Src/Boot/BootMenuEvent.asm

@@ -182 +182 @@
     shl     bl,1                ;  drive letter high order bit to CF, Item/Information bit to SF
     jc      SHORT BootMenuPrint_HardDiskMenuitem
+    ; fall through to BootMenuEvent_FallThroughToFloppyMenuitem
         
 ;;; 
@@ -189 +190 @@
 ALIGN JUMP_ALIGN
 BootMenuEvent_FallThroughToFloppyMenuitem:  
-
+    ; fall through to BootMenuPrint_FloppyMenuitem

trunk/XTIDE_Universal_BIOS/Src/Boot/BootMenuPrint.asm

@@ -32 +32 @@
     jmp     short BootMenuPrint_FormatCSSIfromParamsInSSBP
 
+%ifndef CHECK_FOR_UNUSED_ENTRYPOINTS
 %if BootMenuPrint_FloppyMenuitem <> BootMenuEvent_FallThroughToFloppyMenuitem
 %error "BootMenuPrint.asm must follow BootMenuEvent.asm, and BootMenuPrint_FloppyMenuitem must be the first routine in BootMenuPrint.asm"
 %endif
-
+%endif
         
 ;--------------------------------------------------------------------
@@ -174 +175 @@
     db      2880  / FloppyTypes.rgbCapacityMultiplier    ;  type 6
 
+%ifndef CHECK_FOR_UNUSED_ENTRYPOINTS
 %if g_szFddFiveQuarter <> g_szFddThreeHalf+g_szFddThreeFive_Displacement
 %error "FddThreeFive_Displacement incorrect"
+%endif
 %endif
         
@@ -225 +228 @@
     cmp     bl, FLOPPY_TYPE_525_HD
     ja      .ThreeHalf
+%ifndef CHECK_FOR_UNUSED_ENTRYPOINTS
 %if g_szFddThreeFive_Displacement = 2       
     inc     ax                      ; compressed string case
@@ -230 +234 @@
 %else
     add     ax, g_szFddThreeFive_Displacement
+%endif
 %endif
 .ThreeHalf:     

trunk/XTIDE_Universal_BIOS/Src/Boot/BootMenuPrintCfg.asm

@@ -26 +26 @@
     eMOVZX  ax, BYTE [di+DPT.bIdevarsOffset]
     xchg    si, ax                      ; CS:SI now points to IDEVARS
-    ; Fall to PushAndFormatCfgString
+    ; Fall to .PushAndFormatCfgString
 
 ;--------------------------------------------------------------------
@@ -38 +38 @@
 ;       AX, DX, SI, DI
 ;--------------------------------------------------------------------
-PushAndFormatCfgString:
+.PushAndFormatCfgString:
     push    bp
     mov     bp, sp
@@ -53 +53 @@
 ;       AX, BX
 ;--------------------------------------------------------------------
-PushAddressingMode:
+.PushAddressingMode:
     CustomDPT_GetUnshiftedAddressModeToALZF
     ;; 
@@ -76 +76 @@
 ;       AX
 ;--------------------------------------------------------------------
-PushBlockMode:
+.PushBlockMode:
     mov     ax, 1
     test    BYTE [di+DPT.bFlagsHigh], FLGH_DPT_BLOCK_MODE_SUPPORTED
@@ -94 +94 @@
 ;       AX, DX
 ;--------------------------------------------------------------------
-;PushBusType:
+.PushBusType:
     mov     al,g_szBusTypeValues_Displacement
     mul     BYTE [cs:si+IDEVARS.bDevice]
@@ -113 +113 @@
 ;       AX, DX
 ;--------------------------------------------------------------------
-PushIRQ:
+.PushIRQ:
     eMOVZX  ax, BYTE [cs:si+IDEVARS.bIRQ]
     push    ax
@@ -127 +127 @@
 ;       AX
 ;--------------------------------------------------------------------
-PushResetStatus:
+.PushResetStatus:
     mov     al, [di+DPT.bFlagsHigh]
     and     ax, MASKH_DPT_RESET
@@ -141 +141 @@
 ;       AX, SI, DI
 ;--------------------------------------------------------------------
-PrintValuesFromStack:
+.PrintValuesFromStack:
     mov     si, g_szCfgFormat
     jmp     BootPrint_BootMenuPrint_FormatCSSIfromParamsInSSBP_Relay