Changeset 184 in xtideuniversalbios

Timestamp:

Nov 15, 2011, 5:21:19 AM (13 years ago)

Author:

gregli@…

google:author:

gregli@hotmail.com

Message:

Space optimization, added a new format character 'I' which is the same as 'u' but shows a dash if the operand is zero. Replaces the PushIRQ functionality in bootmenuprintcfg.asm. This only saves a few bytes now, but saves significantly more with the string compression code.

Location:

trunk

Files:

• Assembly_Library/Src/Display/DisplayFormat.asm (modified) (4 diffs)
• XTIDE_Universal_BIOS/Src/Boot/BootMenuPrintCfg.asm (modified) (1 diff)
• XTIDE_Universal_BIOS/Src/Strings.asm (modified) (2 diffs)

trunk/Assembly_Library/Src/Display/DisplayFormat.asm

@@ -128 +128 @@
 .rgcFormatCharToLookupIndex:
 %ifndef EXCLUDE_FROM_XTIDE_UNIVERSAL_BIOS
-    db      "aAduxsSct-+%"
+    db      "aIAduxsSct-+%"
 %else
-    db      "Auxsc-"        ; Required by XTIDE Universal BIOS
+    db      "IAuxsc-"       ; Required by XTIDE Universal BIOS
 %endif
 .rgcFormatCharToLookupIndexEnd:
@@ -138 +138 @@
     dw      a_FormatAttributeForNextCharacter
 %endif
+    dw      I_FormatDashForZero
     dw      A_FormatAttributeForRemainingString
 %ifndef EXCLUDE_FROM_XTIDE_UNIVERSAL_BIOS
@@ -320 +321 @@
 %endif
 
-ALIGN JUMP_ALIGN
+ALIGN JUMP_ALIGN        
 u_FormatUnsignedDecimalWord:
     mov     ax, [bp]
@@ -335 +336 @@
 
 ALIGN JUMP_ALIGN
+I_FormatDashForZero:
+    mov     ax, [bp]
+    test    ax,ax
+    jnz     u_FormatUnsignedDecimalWord     
+    mov     [bp], word g_szDashForZero
+;;; fall-through
+        
+ALIGN JUMP_ALIGN
 s_FormatStringFromSegmentCS:
     xchg    si, [bp]

trunk/XTIDE_Universal_BIOS/Src/Boot/BootMenuPrintCfg.asm

@@ -143 +143 @@
 ;--------------------------------------------------------------------
 PushIRQ:
-    mov     dl, ' '                     ; Load space to DL
-    mov     al, [cs:si+IDEVARS.bIRQ]
-    test    al, al                      ; Interrupts disabled?
-    jz      SHORT .PushIrqDisabled
-    add     al, '0'                     ; Digit to ASCII
-    cmp     al, '9'                     ; Only one digit needed?
-    jbe     SHORT .PushCharacters
-
-    ; Two digits needed
-    sub     al, 10                      ; Limit to single digit ASCII
-    mov     dl, '1'                     ; Load '1 to DX
-    jmp     SHORT .PushCharacters
-ALIGN JUMP_ALIGN
-.PushIrqDisabled:
-    mov     al, '-'                     ; Load line to AL
-    xchg    ax, dx                      ; Space to AL, line to DL
-ALIGN JUMP_ALIGN
-.PushCharacters:
-    push    dx
+    eMOVZX  ax, BYTE [cs:si+IDEVARS.bIRQ]
     push    ax
 

trunk/XTIDE_Universal_BIOS/Src/Strings.asm

@@ -36 +36 @@
 g_szSizeDual:   db  "%s%4-u.%u %ciB / %4-u.%u %ciB",LF,CR,NULL
 g_szCfgHeader:  db  "Addr.",SINGLE_VERTICAL,"Block",SINGLE_VERTICAL,"Bus",  SINGLE_VERTICAL,"IRQ",  SINGLE_VERTICAL,"Reset",LF,CR,NULL
-g_szCfgFormat:  db  "%s"   ,SINGLE_VERTICAL,"%5-u", SINGLE_VERTICAL,"%s",SINGLE_VERTICAL," %c%c",SINGLE_VERTICAL,"%5-x",  NULL
+g_szCfgFormat:  db  "%s"   ,SINGLE_VERTICAL,"%5-u", SINGLE_VERTICAL,"%s",SINGLE_VERTICAL," %2-I",SINGLE_VERTICAL,"%5-x",  NULL
         
 g_szAddressingModes:                    
@@ -64 +64 @@
 g_szSelectionTimeout:   db      DOUBLE_BOTTOM_LEFT_CORNER,DOUBLE_LEFT_HORIZONTAL_TO_SINGLE_VERTICAL,"%ASelection in %2u s",NULL
 
+g_szDashForZero:        db      "- ",NULL