Changeset 105 in xtideuniversalbios for trunk/Assembly_Library/Src/Menu

Timestamp:

Feb 17, 2011, 2:52:42 PM (14 years ago)

Author:

Tomi Tilli

google:author:

aitotat

Message:

Changes to Assembly Library:

• More optimizations to reduce size.
• Removed some utility functions to reduce size.

Location:

trunk/Assembly_Library/Src/Menu

Files:

• Dialog/DialogFile.asm (modified) (4 diffs)
• MenuBorders.asm (modified) (1 diff)
• MenuLoop.asm (modified) (5 diffs)
• MenuScrollbars.asm (modified) (4 diffs)
• MenuTime.asm (modified) (3 diffs)

trunk/Assembly_Library/Src/Menu/Dialog/DialogFile.asm

@@ -45 +45 @@
 .ItemSelectedFromCX:
     call    LoadItemStringBufferToESDI
-    Registers_CopyESDItoDSSI
+    COPY_ESDI_to_DSSI
     call    ItemLineSplitter_GetLineToDSSIandLengthToCXfromStringInDSSIwithIndexInCX
     jmp     ParseSelectionFromItemLineInDSSI
@@ -128 +128 @@
     call    RemoveLastLFandTerminateESDIwithNull
 
-    Registers_CopySSBPtoDSSI
+    COPY_SSBP_TO_DSSI
     xor     ax, ax
     call    Dialog_EventInitializeMenuinitFromDSSIwithHighlightedItemInAX
@@ -198 +198 @@
 ALIGN JUMP_ALIGN
 .ClearDLifInRootDirectory:
-    Registers_CopyESDItoDSSI
+    COPY_ESDI_to_DSSI
     call    Directory_WriteCurrentPathToDSSI
     mov     dl, [si]
@@ -374 +374 @@
 ALIGN JUMP_ALIGN
 SortDirectoryContentsStringFromESDIwithCountInCX:
-    Registers_CopyESDItoDSSI
+    COPY_ESDI_to_DSSI
     call    .AddDirectoryContentsStringLengthToDI
     mov     bx, .FileStringComparator

trunk/Assembly_Library/Src/Menu/MenuBorders.asm

@@ -394 +394 @@
     db      DOUBLE_BOTTOM_LEFT_CORNER
     db      DOUBLE_LEFT_HORIZONTAL_TO_SINGLE_VERTICAL
-    db      "%AAutoselection in %2u s",NULL
+    db      "%ASelection in %2u s",NULL
 
 

trunk/Assembly_Library/Src/Menu/MenuLoop.asm

@@ -1 @@
-; File name     :   MenuLoop.asm
 ; Project name  :   Assembly Library
-; Created date  :   22.7.2010
-; Last update   :   25.11.2010
-; Author        :   Tomi Tilli
 ; Description   :   Menu loop for waiting keystrokes.
 
@@ -22 +18 @@
     call    KeystrokeProcessing
     call    TimeoutProcessing
-    call    IdleTimeProcessing
+    call    MenuEvent_IdleProcessing    ; User idle processing
     test    BYTE [bp+MENU.bFlags], FLG_MENU_EXIT
     jz      SHORT MenuLoop_Enter
@@ -29 +25 @@
 
 ;--------------------------------------------------------------------
-; IdleTimeProcessing
+; KeystrokeProcessing
 ; TimeoutProcessing
-; KeystrokeProcessing
 ;   Parameters
 ;       SS:BP:  Ptr to MENU
@@ -40 +35 @@
 ;--------------------------------------------------------------------
 ALIGN JUMP_ALIGN
-IdleTimeProcessing:
-    jmp     MenuEvent_IdleProcessing        ; User idle processing
+KeystrokeProcessing:
+    call    Keyboard_GetKeystrokeToAX
+    jnz     SHORT ProcessKeystrokeFromAX
+NoKeystrokeToProcess:
+    ret
 
 ALIGN JUMP_ALIGN
 TimeoutProcessing:
     call    MenuTime_UpdateSelectionTimeout
+    jnc     NoKeystrokeToProcess
     mov     ah, MENU_KEY_ENTER              ; Fake ENTER to select item
-    jc      SHORT ProcessKeystrokeFromAX    ; Process faked ENTER
-    ret
-
-ALIGN JUMP_ALIGN
-KeystrokeProcessing:
-    call    Keyboard_GetKeystrokeToAX
-    jnz     SHORT ProcessKeystrokeFromAX
-    ret
+    ; Fall to ProcessKeystrokeFromAX
 
 
@@ -74 +66 @@
     xchg    ax, cx
     call    .ProcessMenuSystemKeystrokeFromAX
-    jc      SHORT .Return
+    jc      SHORT NoKeystrokeToProcess
     jmp     MenuEvent_KeyStrokeInAX
-ALIGN JUMP_ALIGN, ret
-.Return:
-    ret
 
 ;--------------------------------------------------------------------

trunk/Assembly_Library/Src/Menu/MenuScrollbars.asm

@@ -1 @@
-; File name     :   MenuScrollbars.asm
 ; Project name  :   Assembly Library
-; Created date  :   20.7.2010
-; Last update   :   9.12.2010
-; Author        :   Tomi Tilli
 ; Description   :   Functions for drawing scroll bars over menu borders.
 
@@ -185 +181 @@
 
 ;--------------------------------------------------------------------
-; .IsItemInCXonVisiblePage
+; MenuScrollbars_IsItemInCXonVisiblePage
 ;   Parameters
 ;       CX:     Item whose visibility is to be checked
@@ -197 +193 @@
 ALIGN JUMP_ALIGN
 MenuScrollbars_IsItemInCXonVisiblePage:
-    cmp     cx, [bp+MENUINIT.wItems]
-    jae     SHORT .ItemIsNotVisible
-
     cmp     cx, [bp+MENU.wFirstVisibleItem]
     jb      SHORT .ItemIsNotVisible
@@ -215 +208 @@
 
 ;--------------------------------------------------------------------
-; MenuLocation_GetLastVisibleItemOnPageToAX
+; MenuScrollbars_GetLastVisibleItemOnPageToAX
 ;   Parameters
 ;       SS:BP:  Ptr to MENU

trunk/Assembly_Library/Src/Menu/MenuTime.asm

@@ -1 @@
-; File name     :   MenuTime.asm
 ; Project name  :   Assembly Library
-; Created date  :   25.7.2010
-; Last update   :   30.11.2010
-; Author        :   Tomi Tilli
 ; Description   :   Menu timeouts other time related functions.
 
@@ -41 +37 @@
 MenuTime_StopSelectionTimeout:
     test    BYTE [bp+MENU.bFlags], FLG_MENU_TIMEOUT_COUNTDOWN
-    jz      SHORT .TimeoutAlreadyStopped
+    jz      SHORT TimeoutAlreadyStopped
     and     BYTE [bp+MENU.bFlags], ~FLG_MENU_TIMEOUT_COUNTDOWN
     jmp     MenuBorders_RedrawBottomBorderLine
-ALIGN JUMP_ALIGN
-.TimeoutAlreadyStopped:
-    ret
 
 
@@ -77 +70 @@
     call    MenuBorders_RedrawBottomBorderLine
     clc
-ALIGN JUMP_ALIGN
 .ReturnSinceTimeoutDisabled:
+TimeoutAlreadyStopped:
     ret